Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for extension domain name, similar to how it's done for security plugin. More about that in the task: [Extensions] Add support for extension_dns list in extensions.yml file#2730
Issues Resolved
[Extensions] Add support for extension_dns list in extensions.yml file#2730
Currently the implementation looks like this:
PR on openserch-core side: opensearch-project/OpenSearch#8665
I'm in the process of writing tests. Main issue I'm facing right now is that I'm wondering if the overall process looks good. Is the validation logic on the right side? Maybe core side should wait for extension response and then accept/reject call?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.